Add back #keyword in Pragma for compatibility #14897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g later a way to tag methods as compatibility similar to deprecation (that then will never be removed)
|
Marcus why not starting to tag such method with so that we know it. |
|
It is in a "compatibility" category, which is kind of tag so we will find it when we have some real mechanism for managing compatibility methods. I did not want to do more (e.g deciding on a pragma?) as this is not on my active list of things that I work on now and we should at least think a little bit before. Sometimes I just can't start yet another project... |
MarcusDenker
deleted the
14303-Pragmakeyword-has-been-lost-so-breaking-rules-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add back #keyword as a compatibility method, we are thinking of adding later a way to tag methods as compatibility similar to deprecation (that then will never be removed)
fixes #14303