Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Unix Domain Sockets #15167

Open
wants to merge 1 commit into
base: Pharo12
Choose a base branch
from

Conversation

fcr--
Copy link

@fcr-- fcr-- commented Oct 29, 2023

There was already some degree of support, but as seen in this blog post a few more changes were required:

https://samadhiweb.com/blog/2013.07.27.unixdomainsockets.html

fixes #4046

I was testing it with:

sa := NetNameResolver addressForUnixDomain: '/tmp/sp'.
Socket newIPC ifNotNil: [ :s |
	s connectTo: sa.
	s sendData: 'Hello from Smalltalk!'.
	Transcript show: s receiveData; cr.
	s closeAndDestroy. ].

image

There was already some degree of support, but as seen in this blog
post a few more changes were required:

https://samadhiweb.com/blog/2013.07.27.unixdomainsockets.html

fixes pharo-project#4046
@welcome
Copy link

welcome bot commented Oct 29, 2023

Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged.

@svenvc
Copy link
Contributor

svenvc commented Oct 29, 2023

Hi Fransisco,

Thanks for your contribution. I have looked at your changes briefly.

Now, you are probably not aware that some of the networking stuff is developed in Zinc HTTP Components in a separate repository. We just recently added some code in this area as well. Now we need to compare the two of them. In any case, we were also able to get the client side working, but got stuck on the server side part which we wanted to be able to write unit tests.

There is a new package https://github.com/svenvc/zinc/tree/master/repository/Zinc-HTTP-UnixSocket.package

You can check some of our commits from Aug 30 https://github.com/svenvc/zinc/commits/master or some of the closed PRs https://github.com/svenvc/zinc/pulls?q=is%3Apr+is%3Aclosed which contain conversations about this subject.

It would be great if we (me and @JurajKubelka) could work together somehow.

Sven

@Ducasse
Copy link
Member

Ducasse commented Nov 12, 2023

Thanks. This is super nice to see some collaborations on such topics!
We are going in this iteration over a massive internal cleaning and we are getting there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Unix domain sockets.
4 participants