-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo "Revert "Deprecate String>>asDate" #15232
Redo "Revert "Deprecate String>>asDate" #15232
Conversation
@@ -1,7 +1,7 @@ | |||
Extension { #name : 'Project' } | |||
|
|||
{ #category : '*Calypso-SystemQueries' } | |||
Project class >> convertToCalypsoBrowserItem: aProject [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this change because of a merge. @jecisc do you know why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea where those "classSide" are coming from.. I've see it in the past in some projects but I never discovered why.
I never do my merges with Pharo, maybe it's the Pharo merger that uses another printer?
They work in my local image based on build 1020. Pharo 12.0.0 |
This is a known failure I'm working on that appears really recently: #15282 The error is really strange because it happens when updating the users of a trait, but the trait is generated in the tests and has no user (: I'll try to fix it this week |
Oh! Not my fault! Then I can remove the WIP from this PR :) |
Why closing it instead of merging it? |
…t-15228-revert-15227-revert-15152-clean/dates
…1-revert-15228-revert-15227-revert-15152-clean/dates
Redo #15152, originally reverted because there are still broken tests.
Date>>asDate is ambiguous regarding how to interpret the day, month and year fields. Sometimes it interprets them in some order and sometimes in other.
Recently an exception was added in one of the cases above, but the ambiguity remains.
We propose with @guillep to deprecate it in favor of
#readFrom:pattern:
with an explicit pattern.We deprecate methods:
Remove related tests on the deprecated methods.
Use Date>>#readFrom:pattern: specifying a concrete pattern instead + all other.
We also added an option into the pattern parser to continue parsing using the continueAfterParsing method.