Prevent undeclared to be associations #15306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undeclared should only contain UndeclaredVariables but currently it seems that some places (the bootstrap?) are still using association. Here I am trying to force the usage of the variable to find the missbehaving places
|
@MarcusDenker With this PR I found out that we had a case were we do not put an undeclared in the undeclareds and this is in Espell: And We put a nil there. Since we cannot patch Espell for now maybe we could do a nil management in UndeclaredRegistry? |
jecisc
added
Status: Need more work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undeclared should only contain UndeclaredVariables but currently it seems that some places (the bootstrap?) are still using association. Here I am trying to force the usage of the variable to find the missbehaving places