Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MCPatchBrowser #15376

Merged

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Nov 15, 2023

This browser is not used anymore and contains code thet use called but not implemented so it is not even functional

This browser is not used anymore and contains code thet use called but not implemented so it is not even functional
@Ducasse
Copy link
Member

Ducasse commented Nov 16, 2023

Beginning to run tests of ThreadedFFI-UFFI-Tests
PrimitiveFailed: primitive #primFreeDefinition in TFFunctionDefinition failed
TFFunctionDefinition(ProtoObject)>>primitiveFailed:
TFFunctionDefinition(ProtoObject)>>primitiveFailed
TFFunctionDefinition>>primFreeDefinition

Is breaking
I think that this is not related
@tesonep

@Ducasse
Copy link
Member

Ducasse commented Nov 16, 2023

Look nice.

@Ducasse
Copy link
Member

Ducasse commented Nov 16, 2023

Now waiting for the tests to run.

@MarcusDenker
Copy link
Member

There is a problem that TFFunctionDefinition>>primFreeDefinition started crashing and we have no idea why

Due to this, tests can not be run so all PRs are on hold for now

@Ducasse Ducasse closed this Nov 16, 2023
@Ducasse Ducasse reopened this Nov 16, 2023
@Ducasse Ducasse merged commit bf270fe into pharo-project:Pharo12 Nov 16, 2023
1 of 2 checks passed
@jecisc jecisc deleted the monticello/remove-patch-browser branch November 16, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants