Fix inconsistent behavior after BlockCannotReturn exception; fixes issue #15433 #15443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to add a test about this problem :) |
|
Indeed :) |
|
No doubt; I need figure out how, and safely. Aimed for some feedback in the meantime ;) |
…ust open a debugger when computation terminated situation occurs
|
I guess now the solution is clean and testable. If you remove the PS: not sure why two tests failed, seems to be unrelated. |
|
Thanks! We will check quickly this time :) |
MarcusDenker
approved these changes
Nov 29, 2023
isCzech
deleted the
15433-Bug-in-Context--cannotReturn-causing-VM-crash-and-illegal-return
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following examples:
[[^ 1] on: BlockCannotReturn do: #resume ] fork. "VM crash"[[true ifTrue: [^ 1]] on: BlockCannotReturn do: #resume ] fork. "Illegal return from ^1"Both examples will consistently cause a walk-back indicating an illegal return attempt.