Fix infinite loop in ThemeIcons when icon #blank is missing #15570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 0@0 instead of the #blankIconFormSet when the symbol is #blank to avoid an infinite loop.
jecisc
approved these changes
Nov 27, 2023
Rinzwind
added a commit
to Rinzwind/pharo
that referenced
this pull request
Nov 27, 2023
…loop in ThemeIcons when icon #blank is missing”) to Pharo 11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes ThemeIcons to take into account that the icon named
#blankcould be missing. Due to the changes in pull request #15399, that can currently lead to an infinite loop as#blankIconFormSetsends#iconFormSetNamed:which in turn uses#blankIconFormSetas a fallback when#isReportingNotFoundis false. I encountered the loop while backporting that pull request and some others to Pharo 11: when loading the backport there is a point at which all icons are temporarily missing due to the replacement of the instance variable ‘icons’ by ‘iconsPerScale’.I’m wondering though whether it wouldn’t be better to make
#iconFormSetNamed:always use#notFoundIconFormSetwhen an icon is missing, with#isReportingNotFoundjust determining whether or not that also gets logged on the transcript.