Fix refactoring AddMethodComment #15622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking to RBAddMethodCommentTransformation I discover that it uses
surroundedBy: '"'
instead ofasComment
to convert the string to a SmallTalk comment.So, I first made the modification.
But I discovered that in some cases the first
"
is not duplicated, and the last is so"ABC ABC" becomes: "ABC ABC"""
I saw that in
asComment
there is a special handling of the first"
. So I decided to do the same for the last"
.I added a test for the refactoring and I extended the test case of
asComment
with the edging cases I discovered