Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#ShiftClassBuilder>>fillFor: should not use #sharedVariablesFromString: #15623

Merged
merged 3 commits into from
Nov 29, 2023
Merged

#ShiftClassBuilder>>fillFor: should not use #sharedVariablesFromString: #15623

merged 3 commits into from
Nov 29, 2023

Conversation

MarcusDenker
Copy link
Member

#ShiftClassBuilder>>fillFor: should not use #sharedVariablesFromString:

jecisc
jecisc approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Nov 29, 2023
@MarcusDenker MarcusDenker removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label Nov 29, 2023
@MarcusDenker
Copy link
Member Author

Not that easy

The string variant was used as we have to copy the variables... to not share the instances. But a copy is better...

@MarcusDenker MarcusDenker merged commit 5bda0bb into pharo-project:Pharo12 Nov 29, 2023
1 of 2 checks passed
@MarcusDenker MarcusDenker deleted the fillFor-sharedVariablesFromString branch November 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcusDenker @jecisc