Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in Debugging-Core #15624

Merged
merged 7 commits into from
Nov 29, 2023

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Nov 29, 2023

Debugging-Core is a mess. It has dead code. It has a lot of code that is only used in one other specific package in pharo (so the code could move there). It has code used in the Kernel but not present in the kernel.

Here is a first iteration to clean this package by removing most of the dead code and cleaning a few dependencies problems.

  • Remove BlockLocalTempCounter that was only used in the squeak decompiler
  • Remove InstVarRefLocator that is references only by methods with no sender (this one should be a flag in the header because otherwise this is too slow Marcus told me)
  • Remove the whole concept of longPrintString from object that is used only on IR and compilled methods and fix problems that CompiledCode was implementing methods only working on CompiledMethod
  • Remove lot of extensions with no sender

Next step is to move lot of the remaining classes in OpalCompiler-Tests because they are used only in those tests and flashback tests

@MarcusDenker MarcusDenker merged commit 516cefc into pharo-project:Pharo12 Nov 29, 2023
1 of 2 checks passed
@jecisc jecisc deleted the misc/cleaning-dependencies branch November 30, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants