Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22179-remove-annotateRubricText- #1576

Conversation

MarcusDenker
Copy link
Member

@jecisc
Copy link
Member

jecisc commented Jun 20, 2018

Tests failure:

testCreationTime – Unix32.FileSystem.Tests.Attributes.FileReferenceAttributeTests
testModificationTime – Unix32.FileSystem.Tests.Attributes.FileReferenceAttributeTests

@akgrant43
Copy link
Collaborator

Hi Cyril,

How did you determine what the test failures are? I looked at pipeline.log and couldn't find any reference to FileReferenceAttributeTests or testCreationTime. (sorry, I'm short of time for the next several days, and I added these tests, so would like to help resolve the issue).

Thanks,
Alistair

@jecisc
Copy link
Member

jecisc commented Jun 20, 2018

Hi Alistair,

See this GIF:
2018-06-20_23-16-26

@MarcusDenker MarcusDenker merged commit dfa7d14 into pharo-project:development Jun 21, 2018
@akgrant43
Copy link
Collaborator

Hi Cyril,

Neat GIF, thanks!

I can't reproduce the problem (32 or 64 bits on Ubuntu Linux). I've seen something similar on Windows very occasionally where the time is out by up to 20 seconds. I guess that somewhere the clock is being cached, resulting in the test failing.

It's really supposed to ensure that timezone and DST are being handled correctly, so adding a 30 second grace period isn't really going to invalidate the test.

I'll put it on my todo list.

Thanks again,
Alistair

@MarcusDenker MarcusDenker deleted the 22179-remove-annotateRubricText- branch August 24, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants