Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving-snapshot-process-P11 #16108

Merged
merged 2 commits into from
Feb 14, 2024
Merged

improving-snapshot-process-P11 #16108

merged 2 commits into from
Feb 14, 2024

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Feb 7, 2024 •
edited

  • Correctly handling errors during saveAndQuit
  • Creating an object to handle the snapshot process and errors

Backport of PR #16109

@tesonep
- Correctly handling errors during saveAndQuit
76167b7 
- Creating an object to handle the snapshot process and errors
@tesonep
- Fixing the SaveCommandLineHandler
816158c
guillep
guillep approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks!

@guillep guillep merged commit c8d8228 into pharo-project:Pharo11 Feb 14, 2024
3 checks passed
@guillep guillep deleted the improving-snapshot-process-P11 branch February 14, 2024 15:16
@guillep
Copy link
Member

guillep commented Feb 15, 2024 •
edited by unfurl-links bot

This change broke smalltalk CI

Here is a failing job
https://github.com/pharo-contributions/mutalk/actions/runs/7918397477/job/21619111385?pr=79

 NonBooleanReceiver: proceed for truth.
SnapshotOperation(ProtoObject)>>mustBeBooleanIn:
SnapshotOperation(ProtoObject)>>mustBeBoolean
SmalltalkCI class>>saveAndQuitImage
GitHub
Mutation Testing in Pharo Smalltalk. Contribute to pharo-contributions/mutalk development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tesonep @guillep @MarcusDenker