16133 transforming deprecation should not raise a debugger by default but rewrite the code #16157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P11 and no need to pop up a debugger all the times.
MarcusDenker
added
Status: Tests passed please review!
and removed
more-information-needed
labels
MarcusDenker
approved these changes
Feb 14, 2024
|
Yes, good. In the past the setting was just impacting non-rewriting transforms. Maybe having a dedicated setting could be an idea, but we should try to see if the simple one to have just one setting is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16133 transforming deprecation should not raise a debugger by default but rewrite the code #16157