-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate asFileName and re-write system senders #16169
base: Pharo12
Are you sure you want to change the base?
Deprecate asFileName and re-write system senders #16169
Conversation
Note that FileList senders were not re-written as it is planned to be deprecated too.
If you ask me (which you did not :P) I'd simply remove the calls to asFileName. Also, for the file too long or invalid paths, we are already validating that (it's the OS when we open the file haha !) My take
Thoughts? |
Yes, this PR already moves the method to Deprecated12. It seems this method comes from the ages of Squeak, I've found a single user (CodeExporter) and it lacks testing. |
Now the result is different:
|
I saw now the failures seems not related (@jecisc can you confirm?)
|
Yes. But I've seen failures in the NewTools PR I think |
For P13 |
As reported in #16123, this PR should be applied along with the PR in NewTools-Fuel. It is a small PR to clean dependencies which could bring problems when removing old FileList.
Note that FileList senders were not re-written as it is planned to be deprecated too.