Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding slots in Ring #16247

Merged
merged 1 commit into from Feb 26, 2024
Merged

Fix adding slots in Ring #16247

merged 1 commit into from Feb 26, 2024

Commits on Feb 26, 2024

  1. Fix adding slots in Ring 

    A problem got introduced in ring with this commit: pharo-project@d105e1a

This commit removed an #asOrderedCollection and then we could have slots in an array. With this, it makes it impossible to add a new slot to a class or a trait. 

This change reverts this change and adds a comment about why we are having the #asOrderedCollection

This is necessary to have Moose working in P12
    @jecisc
    jecisc committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fc72424 View commit details
    Browse the repository at this point in the history