Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test failing related due to breakpoint #16249

Conversation

adri09070
Copy link
Contributor

Fix #16245

@adri09070
Copy link
Contributor Author

Fixes CI failures

  • ClyInstallMetaLinkPresenterTest>>testInstallSelectedMetalink and ClyInstallMetaLinkPresenterTest>>testInstallSelectedMetalinkActionButton due to a memory leak of metalinks installed on message sends sent to super in anonymous classes + due to ClyMetaLinkInstallationPresenter that was suggesting all metalink instances for installation, while it should only suggest metalinks that are compatible with the target node. The test was failing because it could randomly select an incompatible metalink and try to install it.
  • DebugPointTest>>testTranscriptDebugPoint: the test uses the transcript but the Transcript we usually use is not the same from the non-interactive transcript used by the CI, which does not understand the same messages (really bad design honestly). This causes a DNU. I don't think I should care about that so I just skipped the test on the Pharo CI.
  • ProperMethodCategorizationTest>>testNoLeadingOrTrailingSpacesInCategoryNames and DebugPointTest>>#testBreakDebugPointOnVariableDetectsNewVariableAccessAfterCompilingNewMethod (quality check tests that were failing)

I think this could be merged @MarcusDenker

Copy link
Member

@MarcusDenker MarcusDenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@MarcusDenker MarcusDenker merged commit 30b9859 into pharo-project:Pharo12 Feb 28, 2024
1 of 2 checks passed
@adri09070
Copy link
Contributor Author

@StevenCostiou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] test failing related due to Breakpoint
2 participants