Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove extract method transformation from UI #16301

Merged
merged 2 commits into from Mar 15, 2024
Merged

Fix: remove extract method transformation from UI #16301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b4d5e
Fix: don't show extract method transformation on UI
balsa-sarenac Mar 15, 2024
af3cf40
Feat: make extract method more accessible
balsa-sarenac Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/SystemCommands-SourceCodeCommands/SycExtractMethodAndOccurrencesCommand.class.st
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ SycExtractMethodAndOccurrencesCommand class >> canBeExecutedInContext: aSourceCo
SycExtractMethodAndOccurrencesCommand class >> methodEditorShortcutActivation [
<classAnnotation>

^CmdShortcutActivation by: $e meta, $m meta, $o meta for: ClySourceCodeContext
^CmdShortcutActivation by: $e meta, $m meta for: ClySourceCodeContext
]

{ #category : 'converting' }
Expand All @@ -48,7 +48,7 @@ SycExtractMethodAndOccurrencesCommand >> defaultMenuIconName [

{ #category : 'accessing' }
SycExtractMethodAndOccurrencesCommand >> defaultMenuItemName [
^ '(R) Extract method and occurrences'
^ '(R) Extract method'
]

{ #category : 'execution' }
Expand Down
4 changes: 2 additions & 2 deletions src/SystemCommands-SourceCodeCommands/SycExtractMethodCommand.class.st
View file
Open in desktop
Expand Up @@ -16,8 +16,8 @@ Class {
{ #category : 'testing' }
SycExtractMethodCommand class >> canBeExecutedInContext: aSourceCodeContext [

^ (super canBeExecutedInContext: aSourceCodeContext) and: [
aSourceCodeContext isMethodSelected not ]
^ false. "(super canBeExecutedInContext: aSourceCodeContext) and: [
aSourceCodeContext isMethodSelected not ]"
]

{ #category : 'testing' }
Expand Down