fixes #16315 dependency browser layout feels wrong #16343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the text from the refresh button, making it an icon only button. Additionally the icon is changed from #refreshIcon to #glamorousRefresh to make its function more clear to the user. Lastly the expansion of the button was disabled in DADependencyTreePresenter class>>defaultLayout.
…ctions. This change adds a SpActionBar Presenter to DADependencyTreePresenters and changes its layout to use it to display the action buttons. The action buttons were changed to accomodate their usage in the action bar, which meant removing their text and changing some of their icons for clarity.
jecisc
reviewed
Mar 25, 2024
| @@ -4,6 +4,7 @@ A PDPackageAnalyzerTreeModel shows all dependent packages from a set of packages | |||
| Class { | |||
| #name : 'DADependencyTreePresenter', | |||
| #superclass : 'DAPackageTreePresenter', | |||
| #classTraits : '{} + TraitedClass', | |||
There was a problem hiding this comment.
I think there is a problem with the Tonel export here.
I've seen messages about this but I did not follow what causes this and what should be done when this happens.
There was a problem hiding this comment.
I see... I didn't notice it. Iceberg didn't show it either. I was using a fresh image when working on the PR. Is there something I can do to fix this?
|
Argh again this bug! |
|
Is it possible for me to edit it by hand or do I need to do a new PR? Do I just have to delete the extra line? |
|
I imagine just remove the extra line and the preceeding , |
|
I edited the file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix for issue #16315. It changes the UI to provide the widgets with their respective space. For this some of the buttons are moved into an SpActionBarPresenter.
See the screenshot below for the new look.
