Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of classes with traits in hierarchy #16383

Closed
wants to merge 1 commit into from
Closed

Fix serialization of classes with traits in hierarchy #16383

wants to merge 1 commit into from

Conversation

PalumboN
Copy link
Collaborator

@PalumboN PalumboN commented Mar 29, 2024 •
edited

Try to fix #16345

Probably related to #16014 (TOCHECK)

image

@PalumboN PalumboN requested review from guillep and jecisc March 29, 2024 15:10
@jecisc
Copy link
Member

jecisc commented Apr 2, 2024

Some tests are failing now. For example:

testRedefinedTraitedClassSubclassClassTraitCompositionIncludesTraitedMetaclass – Unix64.Traits.Tests.TraitSubclassingTraitedClassTest9s
Error
Got {} instead of {} + TraitedClass.
Stacktrace
TestFailure
Got {} instead of {} + TraitedClass.
TraitSubclassingTraitedClassTest(TestAsserter)>>assert:description:resumable:
TraitSubclassingTraitedClassTest(TestAsserter)>>assert:description:
TraitSubclassingTraitedClassTest(TestAsserter)>>assert:equals:
TraitSubclassingTraitedClassTest>>testRedefinedTraitedClassSubclassClassTraitCompositionIncludesTraitedMetaclass
TraitSubclassingTraitedClassTest(TestCase)>>performTest

@jecisc jecisc added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Apr 2, 2024
@guillep guillep added the To fix before release Issure to fix before the upcoming Pharo release label Apr 9, 2024
@estebanlm estebanlm closed this Apr 17, 2024
@estebanlm estebanlm reopened this Apr 17, 2024
@MarcusDenker MarcusDenker reopened this Apr 19, 2024
@MarcusDenker
Copy link
Member

I checked the build artefact: image size and .sources size look good with the fix applied

@estebanlm
Copy link
Member

nice, I am checking the associated errors

@MarcusDenker
Copy link
Member

There are tests failing with this PR:

 testRedefinedTraitedClassSubclassClassTraitCompositionIncludesTraitedMetaclass – Unix64.Traits.Tests.TraitSubclassingTraitedClassTest
 testRedefinedTraitedClassSubclassClassTraitCompositionIncludesTraitedMetaclassAPI2 – Unix64.Traits.Tests.TraitSubclassingTraitedClassTest
 testTraitedClassSubclassClassTraitCompositionIncludesTraitedMetaclass – Unix64.Traits.Tests.TraitSubclassingTraitedClassTest
 testMethodsAddedInMetaclassPresentInSubclassesAfterChangingSuperclass – Unix64.Traits.Tests.TraitTest
 testMethodsAddedInMetaclassPresentInSubclassesAfterRemovingSuperclass – Unix64.Traits.Tests.TraitTest
 testRemovingTraitsRemoveTraitedClassMethodsWithSubclasses – Unix64.Traits.Tests.TraitTest

@estebanlm estebanlm mentioned this pull request Apr 19, 2024
Merged
@MarcusDenker
Copy link
Member

Newer version: #16487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep Awaiting requested review from guillep

@jecisc jecisc Awaiting requested review from jecisc

Assignees
No one assigned
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits. To fix before release Issure to fix before the upcoming Pharo release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tonel export of class trait can be wrong
5 participants
@PalumboN @jecisc @MarcusDenker @estebanlm @guillep