Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old breakpoint system's integration to Calypso #16397

Merged

Conversation

adri09070
Copy link
Contributor

I deleted all commands related to:

  • Breakpoint addition (static/once/conditional) and removal because they have been replaced by BreakDebugPoint (with OnceBehavior and ConditionBehavior),
  • Variable Breakpoint addition and removal because they have been replaced by Debug Points with VariableDebugPointTarget,
  • Watchpoint addition and removal because they have been replaced by WatchDebugPoint,
  • Execution Counter addition and removal because they have been replaced by CountBehavior

Copy link
Contributor

@demarey demarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adri09070 there is a release test failing because there is a missing help for a world menu entry:
Counters menu entry in world menu should have an help.
Could you fix it please?

@adri09070
Copy link
Contributor Author

adri09070 commented Apr 12, 2024

The bootstrap fails because there are errors in spec classes.

I appears also in CI runs for other PRs: https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/PR-16442/1/pipeline

@demarey
Copy link
Contributor

demarey commented Apr 12, 2024

yes, I saw that
We will run the CI again when the spec problem is solved

@demarey demarey merged commit ea0eb1a into pharo-project:Pharo12 Apr 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants