Add support for Epicea file out #16401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Epicea file out of class comments. Add tests.
jecisc
reviewed
Apr 4, 2024
There was a problem hiding this comment.
I am not sure about the hardcoding of Smalltalk here.
For example we have a PR pending to rename Smalltalk into Pharo. And it's not nice to have a global variable.
Maybe self class environment is a little better. I don't know if we can do even better right now
Ok, changed then |
jecisc
reviewed
Apr 5, 2024
Add missing closing parenthesis
Add missing closing parenthesis
jecisc
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: