Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Playground shortcut #16422

Merged
merged 2 commits into from Apr 16, 2024

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Apr 7, 2024

This change updates the open playground shortcut. Until now it was cmd + o + w because the tool was called workspace in the past. We could not use the p because this was used by the monticello browser. But in Pharo 12 we removed the Monticello browser and we can now have a better shortcut cmd + o + p (Command Open Playground).

I also removed some references to the workspace to unify the image around the term "playground".

Fixes #3393

This change updates the open playground shortcut. Until now it was cmd + o + w because the tool was called workspace in the past. We could not use the p because this was used by the monticello browser. But in Pharo 12 we removed the Monticello browser and we can now have a better shortcut cmd + o + p (Command Open Playground).

I also removed some references to the workspace to unify the image around the term "playground".

Fixes pharo-project#3393
jecisc added a commit to pharo-spec/NewTools that referenced this pull request Apr 7, 2024
This should be integrated with this: pharo-project/pharo#16422
@jecisc
Copy link
Member Author

jecisc commented Apr 7, 2024

This should be merge just after this one: pharo-spec/NewTools#738

@tesonep
Copy link
Collaborator

tesonep commented Apr 8, 2024

@jecisc can we keep both for now? I am thinking in a kind of deprecation

@jecisc
Copy link
Member Author

jecisc commented Apr 8, 2024

I tried to have 2 shortcuts. I'll see in the produced image if this works

@guillep
Copy link
Member

guillep commented Apr 8, 2024

Thanks! :)

@jecisc
Copy link
Member Author

jecisc commented Apr 9, 2024

It works fine :)

@MarcusDenker MarcusDenker merged commit 21ba960 into pharo-project:Pharo12 Apr 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl + O + W is not a good idea to open the workspace.
4 participants