Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule to avoid that TestCase rely on Initialize #16513

Merged
merged 4 commits into from
May 9, 2024

Conversation

AngelHely
Copy link
Contributor

This pull request proposes a rule to validate that users do not use initialize but setUp.
#5792

Hely added 2 commits April 23, 2024 16:47
this pull request propose a rule to validate that users do not use initialize but setUp.
#5792
ReSetUpRule become a subclass of ReNodeReWriteRule
@MarcusDenker MarcusDenker reopened this Apr 25, 2024
@jecisc jecisc changed the base branch from Pharo12 to Pharo13 April 25, 2024 22:17
@jecisc
Copy link
Member

jecisc commented Apr 25, 2024

Updating the base to P13 instead of P12

Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need to be improved. I commented in another PR the reason why (and how #ensure: works)

src/General-Rules-Tests/ReUseSetUpRuleTest.class.st Outdated Show resolved Hide resolved
src/General-Rules-Tests/ReUseSetUpRuleTest.class.st Outdated Show resolved Hide resolved
@jecisc jecisc added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Apr 25, 2024
AngelHely and others added 2 commits April 26, 2024 08:58
Co-authored-by: CyrilFerlicot <cyril@ferlicot.me>
Co-authored-by: CyrilFerlicot <cyril@ferlicot.me>
@jecisc jecisc removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label May 9, 2024
@jecisc jecisc merged commit ed8167e into pharo-project:Pharo13 May 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants