Refactor: preconditions return array of preconditions by default #16527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `checkPreconditions` method
|
This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title. |
|
15 tests are failings with this PR. |
jecisc
added
the
Status: Need more work
|
@jecisc where do you see the tests? |
|
|
OK thanks for the info. |
balsa-sarenac
added
Status: Tests passed please review!
and removed
Status: Need more work
|
Failing tests seem unrelated |
|
nice! |
balsa-sarenac
deleted the
refactoring/preconditions-return-array-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't rely on a singe condition with and,or,not (we still use them when needed), but default return value of preconditions is array now.
Also, generateChanges method returns changes by default. A bunch of changes is caused by this, but they are trivial to review.