-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the package Deprecated12, introduce package Deprecated13 #16538
Remove the package Deprecated12, introduce package Deprecated13 #16538
Conversation
This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title. |
This causes a lot of tests to fail. Some of the deprecated code is still used |
Would be good when the Deprecated13 package could be introduced nonetheless already. |
We need to fix these tests in NewTools |
…age. So the other dictionary-like classes started to complaint about different API after removal of the Deprecated12 package
The |
and Roassal.Global.Tests.RSDependencyTest.testDependencies needs to be fixed in Roassal |
God save integrators :-) |
One dependency is nuked with #16657 |
Tests failures are down to 4
unix-64 / Tests-unix-64 / Unix64.UnifiedFFI.Tests.FFIAutoReleaseOptionCalloutTest.testVoidPointerunix-64 / Tests-unix-64 / Unix64.ReleaseTests.ProperPackagesTest.testProperManifestCategorization 0.34 sec 1 |
Fixing multiple calls to deprecated methods here: pharo-spec/NewTools#749 |
And here another one: #16658 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a change to fix one of the failing tests
Co-authored-by: CyrilFerlicot <cyril@ferlicot.me>
There is only one failure left that should be fixed with a PR I did to Pharo soon! |
Remove the package Deprecated12, introduce package Deprecated13