Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the package Deprecated12, introduce package Deprecated13 #16538

Merged
merged 7 commits into from
May 16, 2024

Conversation

pavel-krivanek
Copy link
Collaborator

@pavel-krivanek pavel-krivanek commented Apr 27, 2024

Remove the package Deprecated12, introduce package Deprecated13

Copy link

request-info bot commented Apr 27, 2024

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

@jecisc
Copy link
Member

jecisc commented Apr 28, 2024

This causes a lot of tests to fail. Some of the deprecated code is still used

@jecisc jecisc added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Apr 28, 2024
@astares
Copy link
Member

astares commented Apr 28, 2024

Would be good when the Deprecated13 package could be introduced nonetheless already.

@pavel-krivanek
Copy link
Collaborator Author

We need to fix these tests in NewTools
NewTools.Scopes.Tests.ScopesTest.testClassScopeExcludesClassCreatedAPosteriori 2.7 sec 1
NewTools.Scopes.Tests.ScopesTest.testPackageScopeIncludesClassCreatedAPosteriori

@pavel-krivanek
Copy link
Collaborator Author

pharo-spec/NewTools#743

…age. So the other dictionary-like classes started to complaint about different API after removal of the Deprecated12 package
@pavel-krivanek
Copy link
Collaborator Author

The RSDependencyTest>>#testDependencies seems to fail in the vanilla image as well, not a problem of this PR

@pavel-krivanek
Copy link
Collaborator Author

and Roassal.Global.Tests.RSDependencyTest.testDependencies needs to be fixed in Roassal

@pavel-krivanek
Copy link
Collaborator Author

@pavel-krivanek
Copy link
Collaborator Author

God save integrators :-)

@astares
Copy link
Member

astares commented May 14, 2024

One dependency is nuked with #16657

@jecisc
Copy link
Member

jecisc commented May 15, 2024

Fixing multiple calls to deprecated methods here: pharo-spec/NewTools#749

@jecisc
Copy link
Member

jecisc commented May 15, 2024

And here another one: #16658

Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a change to fix one of the failing tests

src/Deprecated13/ManifestDeprecated13.class.st Outdated Show resolved Hide resolved
Co-authored-by: CyrilFerlicot <cyril@ferlicot.me>
@jecisc jecisc closed this May 16, 2024
@jecisc jecisc reopened this May 16, 2024
@jecisc
Copy link
Member

jecisc commented May 16, 2024

There is only one failure left that should be fixed with a PR I did to Pharo soon!

@jecisc jecisc closed this May 16, 2024
@jecisc jecisc reopened this May 16, 2024
@jecisc jecisc merged commit fb1bc71 into pharo-project:Pharo13 May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants