Make it easier to diagnose mock failures by printing message sends properly and storing the send history in the mock #16555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operly and storing the send history in the mock
|
This fix makes the debugger look like this (which is slightly easier to read and diagnose). I think there are more pragmatic and simple fixes we can make to help make mocks helpful without overdoing things. 
Possibly I should remove the "Expected Message" prefix, so that the messages and failed collections better line up for an easier comparision. |
… a normal messsage send, making it easier to compare in the debugger on a failure. (simpler is better)
…fficult-to-read-in-a-test
|
After previous comment, I tried simplifiying the printOn: and it works better - so have adjusted it: |
MarcusDenker
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably many more fixes to add but this helps a little bit