Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 16430 - String>> asSymbol no protected against concurrent access (alternative solution) #16565

Merged

Conversation

carolahp
Copy link
Contributor

@carolahp carolahp commented May 2, 2024

Proposes solution to issue #16430

Summary

To prevent data races when new symbols are interned into the NewSymbols table, a semaphore is used to protect the critical code section in the method Symbol >> intern

@carolahp carolahp marked this pull request as ready for review May 3, 2024 02:06
@carolahp
Copy link
Contributor Author

carolahp commented May 3, 2024

I see the image was built , but (I think) unrelated tests are failing

@jecisc jecisc closed this May 5, 2024
@jecisc jecisc reopened this May 5, 2024
@tesonep tesonep merged commit 4b0c39f into pharo-project:Pharo13 May 14, 2024
1 of 2 checks passed
@carolahp carolahp deleted the 16430-StringasSymbot-not-protected branch May 14, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants