16569-CI-Pharo13-code-with-halt-was-merged #16570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remvove halt - remove unused ivars fixes pharo-project#16569
|
I wonder if a better idea is not to revert #16525 |
|
Before merging, we need to decide if we do not better revert the PR that introduced these (and many more) problemsl. The revert is here: #16572 |
These methods were only used in extract method transformation and are then mvoed to that class.
balsa-sarenac
approved these changes
May 4, 2024
…alt-was-merged Additional fixes for failures in tests introduced by composite extract method
This was
linked to
issues
May 4, 2024
|
It was painful to work on non Pharo13 so let us lower our pain in Pharo13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16569