Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposition refactoring -> Cleanup: 2 duplicated methods in FreeType #16583

Merged
merged 5 commits into from
May 13, 2024
Merged

proposition refactoring -> Cleanup: 2 duplicated methods in FreeType #16583

merged 5 commits into from
May 13, 2024

Conversation

AngelHely
Copy link
Contributor

This pull request proposes a refactoring for :

  • EmbeddedFreeTypeFontInstaller>>#addFromFileContents:baseName:

  • FreeTypeFontProvider>>#updateFromFile:

pull request proposed by @demarey @DurieuxPol and me

#15265

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label May 7, 2024
@MarcusDenker
Copy link
Member

Builds fails with

Instance of FreeTypeFontProvider did not understand #validEmbeddedCachedInfoFor:index:
FreeTypeFontProvider(Object)>>doesNotUnderstand: #validEmbeddedCachedInfoFor:index:
FreeTypeFontFileUpdator(AbstractFreeTypeFontFile)>>cachedNumFacesFromData:
FreeTypeFontFileUpdator>>updateFromFile:

change name for methods FreeTypeFontFileInstaller >> failedToOpen:ind…
f8ab6e6 
…ex: and FreeTypeFontFileUpdator >> failedToOpen:from:index: + use #whileTrue instead of #whileTrue:
@AngelHely AngelHely requested a review from jecisc May 13, 2024 08:08
@jecisc jecisc merged commit 6b676eb into pharo-project:Pharo13 May 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc approved these changes

Assignees
No one assigned
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AngelHely @MarcusDenker @jecisc