Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Provide a lint rule to check for a "super initialize" call in instance side #initialize methods #16615

Conversation

astares
Copy link
Member

@astares astares commented May 13, 2024

Fix #16614

@astares
Copy link
Member Author

astares commented May 13, 2024

The new lint rule in action:

Screenshot from 2024-05-13 21 30 52

Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if it could have an automatic fix but I'm not sure this is easy to do

@jecisc jecisc merged commit 789ce47 into pharo-project:Pharo13 May 14, 2024
2 checks passed
@astares
Copy link
Member Author

astares commented May 14, 2024

@jecisc Yes - I wonder if rewrite engine is able to cover that. This would be helpful also for other auto-fixes like the rules for a missing "super setUp" or "super tearDown"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Provide a lint rule to check for a "super initialize" call in instance side #initialize methods
2 participants