Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22412-Typo-closeclosed-in-AbstractBinaryFileStream--nextputAll #1765

Merged
merged 1 commit into from Sep 6, 2018
Merged

22412-Typo-closeclosed-in-AbstractBinaryFileStream--nextputAll #1765

merged 1 commit into from Sep 6, 2018

Conversation

cdlm
Copy link
Contributor

@cdlm cdlm commented Sep 5, 2018 •
edited

In AbstractBinaryFileStream >> next:putAll:…

self close ifTrue:… closes the stream and then causes a MustBeBoolean; I'm pretty sure closed is what was intended there ;-)

akgrant43
akgrant43 approved these changes Sep 5, 2018
View reviewed changes
Copy link
Collaborator

@akgrant43 akgrant43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (based on visual inspection, but #close doesn't return a boolean, and #closed is obviously intended).

@MarcusDenker MarcusDenker merged commit c271c7f into pharo-project:development Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akgrant43 akgrant43 akgrant43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdlm @akgrant43 @MarcusDenker