Added Interval>>sort: method that raises a "you can not sort an inter… #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliendelplanque
suggested changes
Oct 18, 2018
| Interval >> sort: aBlock [ | ||
| "What sorting an Interval means is not clear." | ||
|
|
||
| self error: 'you can not sort an interval' |
There was a problem hiding this comment.
Except for the missing capital letter at the beginning of the error message and the dot at the end, this is fine for me. :-)
There was a problem hiding this comment.
I wrote it like that to be consistent with the Interval>>at:put: method:
at: anInteger put: anObject
"Storing into an Interval is not allowed."
self error: 'you can not store into an interval'
There was a problem hiding this comment.
But sure, why not.
…nd ends with a dot. - Interval>>sort: method moved to sorting protocol so that it is in the same protocol as the sort: method of the superclass
juliendelplanque
approved these changes
Oct 18, 2018
|
the case on the issue tracker is https://pharo.fogbugz.com/f/cases/22588/Sorting-an-Interval-raises-an-exception |
|
@MarcusDenker @pavel-krivanek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…val" error
From fogbuz issue:
Interval new sort raises an "#< was sent to nil" exception
(1 to: 5) sort raises an "you can not store into an interval" exception
The Interval class inherits the default #sort: method of SequenceableCollection, which does not work for intervals. I am not sure the concept of sorting an Interval makes sense in the general case. I suggest implementing Interval>>sort: so that it raises an explicit exception: "you can not sort an interval" akin to what Interval>>at:put: does (it raises "you can not store into an interval"). Unless someone has an idea for what "sorting an Interval" could mean.