Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22568-ContextcompleteCallee-is-dead-code-new-pr #1926

Merged
merged 1 commit into from Nov 29, 2018
Merged

22568-ContextcompleteCallee-is-dead-code-new-pr #1926

merged 1 commit into from Nov 29, 2018

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Oct 18, 2018

@jecisc jecisc closed this Oct 23, 2018
@jecisc jecisc reopened this Oct 23, 2018
@jecisc
Copy link
Member Author

jecisc commented Nov 5, 2018

Failing tests are due to the problem we got before on dates.

akgrant43
akgrant43 approved these changes Nov 6, 2018
View reviewed changes
Copy link
Collaborator

@akgrant43 akgrant43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are fixed by PR #1948

@jecisc
Copy link
Member Author

jecisc commented Nov 29, 2018

Any news of this PR? Green tests and two approvals.

@MarcusDenker MarcusDenker merged commit 15bdb55 into pharo-project:development Nov 29, 2018
@jecisc jecisc deleted the 22568-ContextcompleteCallee-is-dead-code branch February 8, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-krivanek pavel-krivanek pavel-krivanek approved these changes

@akgrant43 akgrant43 akgrant43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jecisc @pavel-krivanek @akgrant43 @MarcusDenker