Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20321 add build number to system version #212

Conversation

guillep
Copy link
Member

@guillep guillep commented Aug 17, 2017

SystemVersion right now does not store the build number and it does not print the hash of the commit to reproduce the system.

https://pharo.fogbugz.com/f/cases/20321/Add-build-number-to-SystemVersion

@guillep guillep requested a review from astares August 17, 2017 11:00
@jecisc
Copy link
Member

jecisc commented Aug 17, 2017

@astares
Copy link
Member

astares commented Aug 17, 2017

Very good - works!

Copy link
Member

@astares astares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pavel-krivanek
Copy link
Collaborator

printVersion (command-line handler) should use the new information

@guillep
Copy link
Member Author

guillep commented Aug 18, 2017

I added it in a new commit

@pavel-krivanek
Copy link
Collaborator

it now prints the version with quotes:
[version] 'Pharo7.0' 'Pharo-7.0-alpha.build.5.sha.58d59bb3d176d9a5ba3c3192e5b6c8
is that expected?

@Ducasse Ducasse merged commit a581bfc into pharo-project:development Aug 18, 2017
@guillep guillep deleted the 20321-Add-build-number-to-SystemVersion branch September 11, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants