Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2742-transformLastToReturn-does-the-same-as-addReturn #2743

Merged
merged 2 commits into from Mar 7, 2019
Merged

2742-transformLastToReturn-does-the-same-as-addReturn #2743

merged 2 commits into from Mar 7, 2019

Conversation

MarcusDenker
Copy link
Member

transformLastToReturn does the same as addReturn

fixes #2742

@cdlm cdlm added the review label Mar 1, 2019
@MarcusDenker MarcusDenker mentioned this pull request Mar 1, 2019
Closed
@MarcusDenker
Copy link
Member Author

hmm... failure seems related:

UndefinedObject>>DoIt (unicodeData is Undeclared)
'Errors in script loaded from /builds/workspace/uest_and_branch_Pipeline_PR-2743/32/bootstrap/scripts/01-initialization/03-initUnicode.st'
MessageNotUnderstood: receiver of "utf8Encoded" is nil
UndefinedObject(Object)>>doesNotUnderstand: #utf8Encoded
aBlockClosure(no source code or decompiler available) in File>>basicOpenForWrite: in Block: aBlockClosure(no source code or decompiler availab...etc...
File class>>retryWithGC:until:forFileNamed:

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Mar 1, 2019
@MarcusDenker
keep #transformLastToReturn. #addReturn returns the returnNode, makin…
72c8978 
…g is cumbersom to use.

But transformLastToReturn can just call it.
@MarcusDenker
Copy link
Member Author

The problem is that #addReturn returns the ReturnNode. This would make the callers quite complex, much easier to keep transformLastToReturn (but have it call #addReturn).

PR submitted.

@MarcusDenker MarcusDenker added Status: Need more work The issue is nearly ready. Waiting some last bits. and removed Status: Need more work The issue is nearly ready. Waiting some last bits. labels Mar 4, 2019
@MarcusDenker
Copy link
Member Author

failures are related

@MarcusDenker
Copy link
Member Author

hmm... failures seem to be spec related

@MarcusDenker MarcusDenker merged commit 59c0a05 into pharo-project:Pharo8.0 Mar 7, 2019
@cdlm cdlm removed the review label Mar 7, 2019
@MarcusDenker MarcusDenker removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label Mar 7, 2019
@MarcusDenker MarcusDenker deleted the 2742-transformLastToReturn-does-the-same-as-addReturn branch November 20, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transformLastToReturn does the same as addReturn
2 participants
@MarcusDenker @cdlm