Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2753-betterFileVersionExtraction #2848

Merged
merged 1 commit into from
Mar 17, 2019
Merged

2753-betterFileVersionExtraction #2848

merged 1 commit into from
Mar 17, 2019

Conversation

dionisiydk
Copy link
Contributor

It replaces regex parsing of filename pattern (basename.2.ext) with helper method

@dionisiydk dionisiydk mentioned this pull request Mar 16, 2019
Merged
@dionisiydk
Copy link
Contributor Author

It improves #2753

akgrant43
akgrant43 approved these changes Mar 17, 2019
View reviewed changes
Copy link
Collaborator

@akgrant43 akgrant43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dennis!

For a discussion of why this change is necessary, see #2754.

CI test failures are unrelated.

Approved.

@MarcusDenker MarcusDenker merged commit 5d8263f into pharo-project:Pharo8.0 Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akgrant43 akgrant43 akgrant43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dionisiydk @akgrant43 @MarcusDenker