Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2972-MailAddressTokenizer-doesnt-handle-non-ascii-characters #2973

Merged
merged 1 commit into from Mar 22, 2019
Merged

2972-MailAddressTokenizer-doesnt-handle-non-ascii-characters #2973

merged 1 commit into from Mar 22, 2019

Conversation

akgrant43
Copy link
Collaborator

RFC 6531 allows mail addresses to include characters outside the normal ascii character set.

Extend MailAddressTokenizer to handle these characters (codePoint > 127) and add automated tests.

Thanks to Levente Uzonyi for identifying the issue, appropriate RFC and changes to CSNonAtom in Squeak.

Fixes: #2972

@akgrant
RFC 6531 allows mail addresses to include characters outside the norm…
0808d56 
…al ascii character set.

Extend MailAddressTokenizer to handle these characters (codePoint > 127) and add automated tests.

Thanks to Levente Uzonyi for identifying the issue, appropriate RFC and changes to CSNonAtom in Squeak.

Fixes: pharo-project#2972
@cdlm cdlm added the review label Mar 22, 2019
@akgrant43
Copy link
Collaborator Author

CI crashed, but:

  • The VM crash and failed tests are all pre-existing.
  • This change should be platform independent.
  • It is in a class that doesn't get much use.

So it should be safe to merge.

@akgrant43 akgrant43 mentioned this pull request Mar 22, 2019
Closed
@MarcusDenker MarcusDenker merged commit 80178e8 into pharo-project:Pharo8.0 Mar 22, 2019
@cdlm cdlm removed the review label Mar 22, 2019
@akgrant43 akgrant43 deleted the 2972-MailAddressTokenizer-doesnt-handle-non-ascii-characters branch March 22, 2019 10:10
@akgrant43
Copy link
Collaborator Author

Thanks Marcus & Vincent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentBlondeau VincentBlondeau VincentBlondeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akgrant43 @VincentBlondeau @cdlm @MarcusDenker @akgrant