Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2993-update-slot-comments #2994

Merged
merged 1 commit into from Mar 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Slot-Core/InstanceVariableSlot.class.st
@@ -1,6 +1,6 @@
"
I add some special behavior:
- I override bytecode generation to generate ivar read and write bytecodes
- I override bytecode generation to generate ivar read and write bytecodes
- I print the definition as #name
"
Class {
Expand Down
2 changes: 1 addition & 1 deletion src/Slot-Examples/ComputedSlot.class.st
Expand Up @@ -9,7 +9,7 @@ e.g. make a class lile this:
Object subclass: #TT
slots: { #i => ComputedSlot with: [ :o | o class methods size ] }
classVariables: { }
category: 'TT'
package: 'TT'
"
Class {
#name : #ComputedSlot,
Expand Down
4 changes: 2 additions & 2 deletions src/Slot-Examples/ExampleSlotWithState.class.st
Expand Up @@ -6,9 +6,9 @@ slot, similar to a class variable.

I just overide the methods for reflective read and write (#read and #write:to:), I do not bother to emit bytecode myself but rely on the fallback that the compiler will generate code for reflective read and write (see the emit* method of my superclass).

PharoClassInstaller make: [ :builder |
Smalltalk classInstaller make: [ :builder |
builder name: #A;
slots: { TestSlot named: #iv };
slots: { ExampleSlotWithState named: #iv };
category: #Playground ].


Expand Down