Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3148-backport-2395-to-Pharo-70--Non-ASCII-class-and-author-names-break-SourceFileArraygetPreambleFromat- #3149

Merged
merged 1 commit into from
Apr 11, 2019
Merged

3148-backport-2395-to-Pharo-70--Non-ASCII-class-and-author-names-break-SourceFileArraygetPreambleFromat- #3149

merged 1 commit into from
Apr 11, 2019

Conversation

demarey
Copy link
Contributor

@demarey demarey commented Apr 9, 2019

backport of #2395 Non-ASCII class and author names break SourceFileArray>>#getPreambleFrom:at:

@demarey demarey added the review label Apr 9, 2019
@demarey
Copy link
Contributor Author

demarey commented Apr 9, 2019

fixes issue #3148

guillep
guillep approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.

Maybe @svenvc wants to take a look. He did the original changes in Pharo8.

@svenvc
Copy link
Contributor

svenvc commented Apr 10, 2019

Looks like a straight copy, so OK.

guillep
guillep approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Thanks @demarey !!

@guillep guillep merged commit 12b1738 into pharo-project:Pharo7.0 Apr 11, 2019
@guillep guillep removed the review label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@demarey @svenvc @guillep