3175-RBChange-should-work-on-environment-and-not-Smalltalk-globals #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ems the best choice.
VincentBlondeau
suggested changes
Apr 26, 2019
|
It is hard to review old PRs so this PR has been marked as stale since there has been no activity the last 20 days. It will be closed in 10 days if no further activity occurs. A simple comment will reactivate the PR, but please also consider updating the PR to the latest SNAPSHOT build to make it easier for reviewers. |
|
Theo I like your introduction of a method classNamed: now I prefer my introduction of onSystemDictionary because the systemDictionary is not necessary the one in which the class RBRefactoryChange resides. So could do a new PR which
Tx |
Alisu
deleted the
3175-RBChange-should-work-on-environment-and-not-Smalltalk-globals
branch
Ducasse
added a commit
that referenced
this pull request
May 24, 2019
…ronment-and-not-Smalltalk-globals2 Change at: for classNamed: as ask in PR #3254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove smalltalks references in this case 'self class environment' seems the best choice.
Fixes #3175 .