Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3663-Integrate-Spec-2 #3667

Merged
merged 11 commits into from Jun 29, 2019
Merged

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Jun 27, 2019

Integrate Spec 2.

Remove Spec-Tools and Spec-Inspector since they are now in Spec2.

Fixes #3663

Remove Spec-Tools and Spec-Inspector since they are now in Spec2.

Fixes 3663
@jecisc
Copy link
Member Author

jecisc commented Jun 27, 2019

Important changes

  • ComposablePresenter is now named SpPresenter
  • Rename all classes to start with Sp and not conflict with Spec 1 (a4e5b6f)
  • Integrate Commander2 support (f2c53e9)

New Features

  • Add output port to Text presenter (4db397b)
  • The TablePresenter should have update in API (c33998d)

Bug fixes

  • autoScale in ImagePresenter not changeable (0cc50ae)
  • TreeTableAdapter doesNotUnderstand UpdateMenu (c02f97e)
  • Fix bugs in

Cleaning

  • Remove a lot of useless extension methods
  • Proceed on layout migration (db63ce9)
  • Remove extensions conflicts with Spec 1 (736aa2e)
  • Some methods seems to comes from old widgets implementations (323cfb6)
  • Remove centerWidget company (e7502c5)
  • Finish cleaning of modal (e71eb76)
  • Remove extensions methods that are now in Pharo 8 (f2ae224)
  • Using currentWorld instead World (8104f0e)
  • Cleanup comments and typos in Spec Examples (cd244f1)
  • Fix typo MeruPresenter MenuPresenter (6d10928)
  • SpecSelectionsValueHolder and SpecSelectionValueHolder are not used (4f2a286)
  • Transform value holders into observable slots (39b9bc0)

@Ducasse
Copy link
Member

Ducasse commented Jun 27, 2019

Cyril the PR could be loaded because of

[32] Loaded -> Tool-DependencyAnalyser-Tests-Data-tonel.1 --- tonel:///builds/workspace/uest_and_branch_Pipeline_PR-3667/32/src --- cache
[32] Loaded -> Kernel-Rules-tonel.1 --- tonel:///builds/workspace/uest_and_branch_Pipeline_PR-3667/32/src --- cacheError: This package depends on the following classes:
[32] EyeInspector
[32] You must resolve these dependencies before you will be able to load these definitions:
[32] EyeInspector>>#selectedMessage
[32]
[32] MCPackageLoader(Object)>>notify:
[32] MCPackageLoader>>warnAboutDependencies
[32] MCPackageLoader>>validate
[32] MCPackageLoader>>loadWithNameLike:
[32] MCVersionLoader>>basicLoadWithNameLike:

@jecisc
Copy link
Member Author

jecisc commented Jun 27, 2019

Now there is one related failure. I’ll try to check it soon.

@jecisc
Copy link
Member Author

jecisc commented Jun 27, 2019

Weird, the test pass in the image in the archived files... I'll relaunch.

@jecisc
Copy link
Member Author

jecisc commented Jun 28, 2019

I cannot reproduce locally so I'll update the test to print a better log on failure.

@jecisc
Copy link
Member Author

jecisc commented Jun 28, 2019

Error seems not related

@Ducasse Ducasse merged commit f76fd39 into pharo-project:Pharo8.0 Jun 29, 2019
@Ducasse
Copy link
Member

Ducasse commented Jun 29, 2019

THANKS All tests are green.

@jecisc jecisc deleted the 3663-Integrate-Spec-2 branch November 29, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Spec 2
2 participants