Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3706-INVALID-ISSUE #3707

Merged
merged 1 commit into from Jun 30, 2019
Merged

Conversation

EiichiroIto
Copy link
Contributor

fix case #3706.

fix GIFReadWriter>>readExtensionBlock:withFrame: to support Comment Extension.

@welcome
Copy link

welcome bot commented Jun 30, 2019

Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged.

@Ducasse
Copy link
Member

Ducasse commented Jun 30, 2019

Thanks and great to see you here :)

@Ducasse
Copy link
Member

Ducasse commented Jun 30, 2019

Change looks cool. And broken is unrelated.
So integration.

@Ducasse Ducasse merged commit 53cf143 into pharo-project:Pharo8.0 Jun 30, 2019
@welcome
Copy link

welcome bot commented Jun 30, 2019

Congrats on merging your first pull request! Do another one! We try to have a list of (relatively) easy issues here: https://github.com/orgs/pharo-project/projects/8.

GitHub
GitHub is where people build software. More than 36 million people use GitHub to discover, fork, and contribute to over 100 million projects.

@EiichiroIto
Copy link
Contributor Author

Thank you for your work on integration.

@EiichiroIto EiichiroIto deleted the 3706-INVALID-ISSUE branch July 1, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants