Separate Network-Tests-Mail into new package #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess you do the file rename from the command line, since the class-category was not updated. |
|
Actually, I didn't rename the file. Should the category be #'Network-Tests-Mail-RFC822'? |
|
Oh, I saw this in the File Changed tab... and wondered how the class(/file) changed packages(/directory) without the "Category:" of the class being changed to match the package (as seen inside the file) . Any ideas?
It didn't occur to me, but yes, it might be worth not throwing that info away. |
|
Thanks James. I like this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to load Network-Tests into a minimal image without these tests since they test things that aren't in the minimal image (MailAddressParser, MailAddressTokenizer, and MailMessage). This appears to do it but I've not created a new package before so anticipate issues. Advice and guidance is welcome! Thanks.