Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4152-Cleanups-in-UIManager #4153

Merged
merged 1 commit into from Jul 31, 2019
Merged

4152-Cleanups-in-UIManager #4153

merged 1 commit into from Jul 31, 2019

Conversation

astares
Copy link
Member

@astares astares commented Jul 30, 2019

Cleanups in UIManager

  • no dots at end of methods
  • unify comments to start uppercase and end with dot
  • add missing return
  • unify formatting of similar methods

Fix #4152

@astares
Cleanups in UIManager
9faaa28 
- no dots at end of methods
- unify comments to start uppercase and end with dot
- add missing return
- unify formatting of similar methods

Fix pharo-project#4152
@Ducasse
Copy link
Member

Ducasse commented Jul 31, 2019 •
edited

Thanks torsten.
For the record I add always a space after ^
so...

We will integrate soon an alternate pretty printer with better default.
I'm not sure yet that we can pretty print everything but I will try.

@Ducasse Ducasse merged commit 32c69e2 into pharo-project:Pharo8.0 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanups in UIManager
2 participants
@astares @Ducasse