Fixes issue 3068 #4502
Merged
Fixes issue 3068 #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the is a near solution already in the discussion of the issue. There is a method #firstComment, which should return the first comment. I changed the method to actually return an ordered collection of comments in the method. I changed the test method to depend less on the comments in other parts of the system, and noted where it does.
kasperosterbye
deleted the
3068-comments-method-on-compiled-method-only-considered-the-method-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the is a near solution already in the discussion of the issue.
There is a method #firstComment, which should return the first comment, while #comments should return a list of them all.
I changed the method to return an ordered collection of comments in the method.
I changed the test method to depend less on the comments in other parts of the system, and noted where it does. Obviously I made the test check if two comments can be extracted as well.