Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlotDefTests #4523

Merged
merged 5 commits into from Sep 9, 2019
Merged

SlotDefTests #4523

merged 5 commits into from Sep 9, 2019

Conversation

Ducasse
Copy link
Member

@Ducasse Ducasse commented Sep 8, 2019

Fixes: #4410

  • Better printOn: logic
  • Adding tests

@Ducasse
fixes: #4410
d8ddc13
@Ducasse
- Added private class node factory
5ae8532 
- introducing SlotInitializationNode
- Removing dead code in tests 
- typeName -> slotClassName
@Ducasse
Fixes: #4410
98ba28f 
- introduce SlotInitialization + tests.
@Ducasse
Fixes: #4410
8213c77 
- Introducing null initializationMessage so that we can have polymorphic code
- start and stop are obscure to me right now, so there are not covered by tests or well.
@Ducasse
Fixes: #4410
9890bab 
- Better printOn: logic 
- Adding tests
@tesonep tesonep merged commit 9ef40fd into pharo-project:Pharo8.0 Sep 9, 2019
@Ducasse Ducasse deleted the SlotDefTests branch July 13, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should write a test for the class definition and slot parser error
2 participants
@Ducasse @tesonep