CleanNECContextTest #4921
Merged
CleanNECContextTest #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add explanation to the new test class
myroslavarm
reviewed
Oct 16, 2019
| ] | ||
|
|
||
| { #category : #private } | ||
| CompletionContextTest >> createContextFor: aString at: anInteger [ | ||
| ^ NECContext | ||
| controller: NECController new | ||
| ^ CompletionContext |
There was a problem hiding this comment.
if you are running these tests for the new CompletionContext then SubContextTest class with the tests overrides should be deleted...
There was a problem hiding this comment.
Yes, I renamed the old CompletionContext to NECContextTest and SubContextTest to CompletionContextTest
This way everything is named after what it tests, and SubContextTest is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another cleanup of the tests: remove tests that test the old system, add explanation to the new test class