4953-moduleName-needs-to-be-properly-deprecated #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unrelated test failures |
MarcusDenker
approved these changes
Oct 21, 2019
guillep
reviewed
Oct 21, 2019
There was a problem hiding this comment.
Are the infinite recursions ok? If we disable the automatic rewritings nothing will work...
Besides, this method is supposed to be abstract and redefined in subclasses, so nobody will ever call it actually. That's why I did not deprecate it in my changes, but I'm not against the deprecation on itself.
| deprecated: 'Please use #libraryName instead' | ||
| transformWith: '`@receiver moduleName' -> '`@receiver libraryName'. | ||
|
|
||
| ^self moduleName |
There was a problem hiding this comment.
This is an infinite recursion :/
| deprecated: 'Please use #libraryName instead' | ||
| transformWith: '`@receiver moduleName' -> '`@receiver libraryName'. | ||
|
|
||
| ^self moduleName |
|
damn |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add moduleName deprecation
fixes #4953