Backport-5072-MCClassTraitDefinition-should-take-category-into-account-for-equality #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Pharo 7, the loading of code is using a cache for MCDefinitions. When you create a new definition, it checks if one equivalent was already created, if yes, it return this one. The equality of MCClassTraitDefinition does not take the category into account and I got bug while loading code because the MCClassTraitDefinition was wrong because it found one with another category.
|
Backport of #5072 |
|
Any news on this? I still get the bug in Pharo 7 and it's pretty annoying :( |
myroslavarm
approved these changes
Nov 23, 2019
|
The broken tests seems unrelated. |
jecisc
deleted the
Backport-5072-MCClassTraitDefinition-should-take-category-into-account-for-equality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a bug while loading code.
In Pharo 7, the loading of code is using a cache for MCDefinitions.
When you create a new definition, it checks if one equivalent was already created, if yes, it return this one.
The equality of MCClassTraitDefinition does not take the category into account and I got bug while loading code because the MCClassTraitDefinition was wrong because it found one with another category.