Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5896 detected error in extreme rare cases for slider #5897

Conversation

David5i6
Copy link
Contributor

fixes #5896

There where error on some extremely rare cases.

Also a bug when clicking outside the slider handler is corrected.

Code is documented (Perhaps too verbose).

Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think the comments are great to understand the problem.

self model ifNotNil: [
self setValueSelector ifNotNil: [:sel |
self model perform: sel with: scaled]]
self model perform: sel with: value ]]
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@guillep guillep merged commit f5eedef into pharo-project:Pharo9.0 Mar 15, 2020
@guillep guillep mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected error in extreme rare cases for Slider
2 participants